Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BF] fix intendedFor #107

Merged
merged 6 commits into from
Apr 14, 2022
Merged

Conversation

arnaudbore
Copy link
Contributor

More robust way to auto fill the intendedFor key in the json file.

Tests need to be re-written but should be working.

Fix #106

@arnaudbore arnaudbore changed the title [BF] fix intendedFor [WIP][BF] fix intendedFor Jan 22, 2021
@bwagnerwork
Copy link
Collaborator

I'm having a bit of trouble telling from the code. Would this intended for fix work in a scenario where dcm2bids is run over a dataset several times (such as updating rules do to variations) or intended for single run or a clean rerun if needed?

@arnaudbore
Copy link
Contributor Author

This should work with a clean run not a rerun. At this stage, I check if there is any intended for then I check the rest of the images that are going to be converted and see which one could fit. If an image has already been converted it won't work... good point. 👍

@arnaudbore arnaudbore changed the title [WIP][BF] fix intendedFor [BF] fix intendedFor Apr 14, 2022
@arnaudbore arnaudbore merged commit 5080559 into UNFmontreal:master Apr 14, 2022
@arnaudbore arnaudbore deleted the fix_intendedFor branch July 3, 2023 22:15
@arnaudbore arnaudbore restored the fix_intendedFor branch July 3, 2023 22:15
@arnaudbore arnaudbore deleted the fix_intendedFor branch July 3, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntendedFor JSON field suffix always ".nii.gz"
2 participants