Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade feature Intended for #207

Merged
merged 13 commits into from
Jun 12, 2023

Conversation

arnaudbore
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #207 (9e8eb90) into master (803848e) will increase coverage by 0.77%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   78.00%   78.78%   +0.77%     
==========================================
  Files          15       15              
  Lines         773      773              
  Branches      109      111       +2     
==========================================
+ Hits          603      609       +6     
+ Misses        138      134       -4     
+ Partials       32       30       -2     
Flag Coverage Δ
pytest 78.78% <96.29%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dcm2bids/cli/dcm2bids.py 84.00% <ø> (+5.42%) ⬆️
dcm2bids/sidecar.py 87.50% <ø> (-0.09%) ⬇️
dcm2bids/dcm2bids_gen.py 82.56% <87.50%> (+3.47%) ⬆️
dcm2bids/acquisition.py 98.24% <100.00%> (+0.08%) ⬆️
dcm2bids/participant.py 100.00% <100.00%> (ø)
dcm2bids/utils/utils.py 76.47% <100.00%> (+0.47%) ⬆️

Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id field works great but I wonder whether we should keep the former method as well to prevent current pipeline from breaking as all config files would need to be updated. So maybe printing a warning instead of an error?

@arnaudbore arnaudbore merged commit d823293 into UNFmontreal:master Jun 12, 2023
11 checks passed
@arnaudbore arnaudbore deleted the add_feature_intended_for branch July 3, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants