Generalization of sidecarchanges using ids #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fix #211 |
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
- Coverage 80.31% 80.13% -0.19%
==========================================
Files 15 15
Lines 879 876 -3
Branches 143 145 +2
==========================================
- Hits 706 702 -4
Misses 140 140
- Partials 33 34 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
SamGuay
approved these changes
Jun 23, 2023
Co-authored-by: Samuel Guay <samuel.guay@umontreal.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now IntendedFor is inside sidecarChanges