Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] dataType -> datatype and modalityLabel -> suffix #214

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

arnaudbore
Copy link
Contributor

No description provided.

@arnaudbore arnaudbore requested a review from SamGuay June 23, 2023 16:15
@codecov-commenter
Copy link

Codecov Report

Merging #214 (e9e3df8) into master (76b9f29) will not change coverage.
The diff coverage is 93.33%.

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   80.13%   80.13%           
=======================================
  Files          15       15           
  Lines         876      876           
  Branches      145      145           
=======================================
  Hits          702      702           
  Misses        140      140           
  Partials       34       34           
Flag Coverage Δ
pytest 80.13% <93.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dcm2bids/cli/dcm2bids.py 84.61% <ø> (ø)
dcm2bids/dcm2bids_gen.py 82.72% <0.00%> (ø)
dcm2bids/acquisition.py 97.36% <100.00%> (ø)
dcm2bids/sidecar.py 86.76% <100.00%> (ø)

Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudbore arnaudbore merged commit bdb8980 into UNFmontreal:master Jun 23, 2023
11 checks passed
@arnaudbore arnaudbore deleted the enh_suffix branch June 23, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants