Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log n version #219

Merged
merged 7 commits into from
Jun 29, 2023
Merged

Fix log n version #219

merged 7 commits into from
Jun 29, 2023

Conversation

SamGuay
Copy link
Member

@SamGuay SamGuay commented Jun 28, 2023

No description provided.

* Removed the curl dependencies in favor of using urllib request.
* Using the github API to get the latest version through "tag_name"
* Improved logging
* raised Error when dcm2niix is not installed to stop dcmbids
log level in the file = DEBUG but user has control over log
level for the console
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #219 (a6f8b94) into master (bdb8980) will decrease coverage by 1.84%.
The diff coverage is 47.29%.

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   80.13%   78.30%   -1.84%     
==========================================
  Files          15       15              
  Lines         876      885       +9     
  Branches      145      169      +24     
==========================================
- Hits          702      693       -9     
- Misses        140      159      +19     
+ Partials       34       33       -1     
Flag Coverage Δ
pytest 78.30% <47.29%> (-1.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dcm2bids/version.py 87.50% <ø> (ø)
dcm2bids/cli/dcm2bids.py 52.54% <25.71%> (-32.08%) ⬇️
dcm2bids/cli/dcm2bids_helper.py 46.29% <27.27%> (-4.93%) ⬇️
dcm2bids/dcm2niix_gen.py 52.72% <33.33%> (ø)
dcm2bids/utils/tools.py 50.00% <41.17%> (+2.70%) ⬆️
dcm2bids/sidecar.py 86.76% <44.44%> (ø)
dcm2bids/dcm2bids_gen.py 77.64% <50.00%> (-5.09%) ⬇️
dcm2bids/utils/logger.py 85.71% <90.90%> (-0.96%) ⬇️
dcm2bids/acquisition.py 97.36% <100.00%> (ø)
dcm2bids/cli/dcm2bids_scaffold.py 92.59% <100.00%> (+2.84%) ⬆️

@SamGuay SamGuay marked this pull request as ready for review June 29, 2023 01:42
@arnaudbore arnaudbore merged commit 3c5ae96 into UNFmontreal:master Jun 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants