Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quick Fix] Add specific message when no acquisition was found #235

Merged
merged 3 commits into from
Jul 15, 2023

Conversation

arnaudbore
Copy link
Contributor

No description provided.

@arnaudbore arnaudbore requested a review from SamGuay July 14, 2023 15:53
Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont think we need print("toto") :D

dcm2bids/dcm2bids_gen.py Outdated Show resolved Hide resolved
dcm2bids/dcm2bids_gen.py Outdated Show resolved Hide resolved
dcm2bids/dcm2bids_gen.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2023

Codecov Report

Merging #235 (b5fd921) into master (43023c7) will increase coverage by 1.24%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   78.05%   79.30%   +1.24%     
==========================================
  Files          15       15              
  Lines         966     1005      +39     
  Branches      197      212      +15     
==========================================
+ Hits          754      797      +43     
+ Misses        170      163       -7     
- Partials       42       45       +3     
Flag Coverage Δ
pytest 79.30% <66.66%> (+1.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dcm2bids/participant.py 100.00% <ø> (ø)
dcm2bids/sidecar.py 81.52% <63.15%> (+3.83%) ⬆️
dcm2bids/dcm2bids_gen.py 80.23% <100.00%> (+0.71%) ⬆️

@arnaudbore arnaudbore merged commit 5a27f2f into UNFmontreal:master Jul 15, 2023
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants