Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BF] fix sidecars suggested by Sam #243

Merged
merged 5 commits into from
Jul 21, 2023
Merged

[BF] fix sidecars suggested by Sam #243

merged 5 commits into from
Jul 21, 2023

Conversation

arnaudbore
Copy link
Contributor

Thank you @SamGuay

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #243 (e5fc6a1) into master (229b5f7) will decrease coverage by 0.32%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   79.30%   78.98%   -0.32%     
==========================================
  Files          15       15              
  Lines        1005     1009       +4     
  Branches      212      214       +2     
==========================================
  Hits          797      797              
- Misses        163      165       +2     
- Partials       45       47       +2     
Flag Coverage Δ
pytest 78.98% <66.66%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dcm2bids/acquisition.py 94.01% <57.14%> (-3.33%) ⬇️
dcm2bids/dcm2bids_gen.py 80.23% <100.00%> (ø)

@arnaudbore
Copy link
Contributor Author

arnaudbore commented Jul 21, 2023

Fix also #242 and #241 :)

docs/how-to/use-advanced-commands.md Outdated Show resolved Hide resolved
docs/how-to/use-advanced-commands.md Outdated Show resolved Hide resolved
docs/how-to/use-advanced-commands.md Outdated Show resolved Hide resolved
docs/how-to/use-advanced-commands.md Outdated Show resolved Hide resolved
docs/how-to/use-advanced-commands.md Outdated Show resolved Hide resolved
docs/how-to/use-advanced-commands.md Outdated Show resolved Hide resolved
docs/how-to/use-advanced-commands.md Outdated Show resolved Hide resolved
docs/how-to/use-advanced-commands.md Outdated Show resolved Hide resolved
docs/how-to/use-advanced-commands.md Outdated Show resolved Hide resolved
docs/how-to/use-advanced-commands.md Outdated Show resolved Hide resolved
Sam suggestions validated

Co-authored-by: Samuel Guay <samuel.guay@umontreal.ca>
@arnaudbore arnaudbore merged commit 03a795a into master Jul 21, 2023
26 checks passed
@arnaudbore arnaudbore deleted the fix_sidecars branch July 22, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants