Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip_dcm2niix and reorganize NIFTI and JSON files #248

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

arnaudbore
Copy link
Contributor

No description provided.

@arnaudbore arnaudbore requested a review from SamGuay July 27, 2023 21:42
@arnaudbore arnaudbore changed the title [WIP] Add option to skip_dcm2niix and reorganize NIFTI and JSON files Add option to skip_dcm2niix and reorganize NIFTI and JSON files Jul 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #248 (4912381) into master (22a9851) will decrease coverage by 0.39%.
The diff coverage is 21.05%.

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   78.98%   78.60%   -0.39%     
==========================================
  Files          15       15              
  Lines        1009     1019      +10     
  Branches      214      217       +3     
==========================================
+ Hits          797      801       +4     
- Misses        165      171       +6     
  Partials       47       47              
Flag Coverage Δ
pytest 78.60% <21.05%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dcm2bids/dcm2niix_gen.py 48.38% <6.25%> (-4.35%) ⬇️
dcm2bids/cli/dcm2bids.py 55.00% <100.00%> (+0.76%) ⬆️
dcm2bids/dcm2bids_gen.py 80.45% <100.00%> (+0.22%) ⬆️
dcm2bids/utils/utils.py 83.51% <100.00%> (+0.18%) ⬆️

Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as it should.

Minor change request:

  1. It is possible to run dcm2bids --skip_dcm2niix --force_dcm2niix [...] which is counter-intuitive. The order doesn't matter as --skip_dcm2niix as priority but still feels odd. Also, in the log, it will also add: WARNING | 'force' argument is set to True which can be hard to interpret when we look back at the logs. We could either modify the warning message or add another one.
  2. When dcm2bids is run multiple times on the same participant, there is another warning that is technically not true but not harmful: WARNING | Previous dcm2niix directory output found:. If one has NII and json, we can't assume it was produced by dcm2niix.

@arnaudbore arnaudbore merged commit 25eb307 into master Aug 10, 2023
27 checks passed
@arnaudbore arnaudbore deleted the add_option_for_nifti_only branch August 10, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants