Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Numericals in JSON custom fields #250

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

smeisler
Copy link
Contributor

@smeisler smeisler commented Aug 7, 2023

Closes #249

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Merging #250 (1e09113) into master (22a9851) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   78.98%   78.59%   -0.40%     
==========================================
  Files          15       15              
  Lines        1009     1009              
  Branches      214      214              
==========================================
- Hits          797      793       -4     
- Misses        165      170       +5     
+ Partials       47       46       -1     
Flag Coverage Δ
pytest 78.59% <0.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
dcm2bids/acquisition.py 94.01% <0.00%> (ø)

... and 1 file with indirect coverage changes

revert: remove conditional searching for strings
@arnaudbore arnaudbore merged commit a4eb1d0 into UNFmontreal:master Aug 10, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sidecar_changes doesn't support int / numerical objects
3 participants