Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BF] Auto extractors and merge regex expressions #275

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Conversation

arnaudbore
Copy link
Contributor

Before this fix, auto_extract_entities was trying to feed all entities found with auto_extractors even if auto_entities was more strict.

Also when providing custom extractors it was overwrote by auto_extractors.

Need some testing, @SamGuay I will send you some data.

… fix merge auto_extractors with custom extractors
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (42cd77b) 75.16% compared to head (51af3f9) 75.25%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   75.16%   75.25%   +0.09%     
==========================================
  Files          15       15              
  Lines        1075     1079       +4     
  Branches      237      239       +2     
==========================================
+ Hits          808      812       +4     
  Misses        220      220              
  Partials       47       47              
Flag Coverage Δ
pytest 75.25% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dcm2bids/sidecar.py 81.13% <100.00%> (+0.11%) ⬆️
dcm2bids/utils/utils.py 84.04% <100.00%> (+0.34%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SamGuay SamGuay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test data were converted successfully! This bf makes it clear whats expected from the user now, I think.

@SamGuay SamGuay merged commit cac5a25 into master Oct 11, 2023
29 checks passed
@arnaudbore arnaudbore deleted the fix_auto_entities branch October 12, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants