Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemap Build Error Fix #88

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Sourcemap Build Error Fix #88

merged 6 commits into from
Mar 27, 2024

Conversation

KingJordan152
Copy link
Contributor

@KingJordan152 KingJordan152 commented Mar 27, 2024

Description

In this PR, I introduce some changes to our package.json and vite.config.ts files that remedies some build errors we were receiving on Vercel. @Linkaloo and I collaborated on this.

Related Issue

This doesn't relate to any issues.

Type of Changes

Please select the relevant option:

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Other (please specify)

Changes

  • Added a Vite plugin that suppresses sourcemap errors (muteWarningsPlugin).
  • Added a Vite plugin that polyfills node modules that are used in service worker files (nodePolyfills).
  • Added an optional Node dependency that's used by Vercel to deploy our builds (@rollup/rollup-linux-x64-gnu).
  • Removed and rebuilt package-lock.json

Things to Update

Please add any features, buttons, or pages that might need updating in the future:

  • Button Functunality
  • Code Documentation
  • Mobile Responsiveness
  • Code testing
  • Other (please specify)

Nothing needs to get updated in the future.

Screenshots

[Insert any relevant screenshots or GIFs to showcase visual changes, if applicable]

N/A

Additional Notes

[Provide any additional information or context for reviewers]

Here are some resources that helped @Linkaloo and I resolve this issue:

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cs472-roadwatch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 5:46pm

@KingJordan152 KingJordan152 self-assigned this Mar 27, 2024
@KingJordan152 KingJordan152 added the ready for review The PR can be reviewed by anyone label Mar 27, 2024
@KingJordan152 KingJordan152 marked this pull request as ready for review March 27, 2024 17:54
Copy link
Contributor

@Linkaloo Linkaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a fun adventure, hopefully it never happens again.

Copy link
Contributor

@RedPenguin88 RedPenguin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that after running npm run build in the client folder, I no longer receive the errors. Thanks for sorting this out.

Copy link
Contributor

@Aligary Aligary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix our build!

@KingJordan152 KingJordan152 merged commit 8a436d4 into main Mar 27, 2024
5 checks passed
@KingJordan152 KingJordan152 mentioned this pull request Mar 28, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The PR can be reviewed by anyone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants