-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify project structure in preparation for Upstream #13
Modify project structure in preparation for Upstream #13
Conversation
|
I've removed all branch restrictions on that workflow and it works as it should:
There is one issue: PR on rust-port trigger the tests twice: once for being a pull request, and one for being a push. A possible fix would be to limit the push event to only the "rust-port" branch, but Pull Requests will be checked regardless of target. |
This is how Tock does all the testing, so that should be fine. |
Alright, I'll leave it as-is then |
I've looked at how Tock does their CI pipeline, and I must admit I'm quite a fan. They want to make sure all checks can be ran on the local version of the repository while keeping code repetition to a minimum. They do this by invoking rules in a Makefile. In my latest commits, I've taken heavy inspiration from them. I've also made two more test forks to make sure they work properly. Failing PR: george-cosma#5 Now, initially, I used a naming scheme similar to that of tock's Makefile, for the sake of consistency. Now, I'm not so certain, they might be a little verbose. |
This pull request solves issue #12
This pull request contains the following changes:
To test the workflow, I've created a dummy pull request which includes a failing test.
george-cosma#2
Questions
There are two issues I'd like to discuss regarding the workflow:
If my understanding of workflows is correct, github runs the workflows if the corresponding config files are found in the source branch of the pull request.
If this is true, then I think we could delete the python-specific workflows because a contributor to the rust version would pull from the "rust-port" branch, where the python workflows would not need to exist, and a contributor to the python version would pull from the "master" branch, where the rust workflow does not exist. Or so I think.
And in regards to my second question, I'm still uncertain of the advantages and disadvantages of testing all pull requests VS testing only the pull requests going towards the "rust-port" branch.