Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe toolbar #92

Open
VladVulturescu opened this issue Apr 8, 2024 · 10 comments
Open

Unsafe toolbar #92

VladVulturescu opened this issue Apr 8, 2024 · 10 comments
Labels

Comments

@VladVulturescu
Copy link
Contributor

VladVulturescu commented Apr 8, 2024

While reading a course, when scrolling backwards too fast, it tries to call a previous slide which does not exist (index out of bounds). it results in a "page not found" issue. below are screenshots with the issue in the console. bug was discovered on macOS 12.3.1, but it can also be replicated on Windows and Linux

How to replicate bug: select a course, pick the last slide and scroll backwards fast

MA - Page not found error - openend console Microprocessor Achitecture - Page not found 2 Microprocessor Architecture website - Page not found

Authors: Vlad Vulturescu vlad.vulturescu@yahoo.com
Andrei Dragota anditu2003@gmail.com

@U-alb
Copy link
Contributor

U-alb commented Apr 8, 2024

I think the issue arises from the following js script
js

Specifically, the button triggers an event that requests the previous slide even if the current index points to the first position

@alexandruradovici
Copy link
Contributor

I not able to reproduce the bug. Please try the loading only the slides using https://embedded-rust-101.wyliodrin.com/slides/05. Does the bug still appear?

@alexandruradovici
Copy link
Contributor

alexandruradovici commented Apr 8, 2024

The problem is from the combining of two projects: docusaurus for the website and slidev used in an iframe. Docusaurus rewrites links to use the react router, which intercept browser requests and stop slidev from working. Insead of making a request to slidev's files, it makes a request that is intercepted by docusaurus that shows the error.

@domnudragota
Copy link
Contributor

Basically while reading the courses, we've clicked too fast going backwards. However, it was at random when this would trigger. We'll see if it works directly on slides.

@VladVulturescu
Copy link
Contributor Author

I not able to reproduce the bug. Please try the loading only the slides using https://embedded-rust-101.wyliodrin.com/slides/05. Does the bug still appear?

I tried using the link provided to only load the slides and the same error occurred when clicking too fast.

MA - Page not found - response 2

@alexandruradovici
Copy link
Contributor

alexandruradovici commented Apr 8, 2024

Are you clicking the browser's back button?

@VladVulturescu
Copy link
Contributor Author

No, I'm using the toolbar in the bottom left of the slide.

Screenshot 2024-04-08 at 14 34 06

If it's relevant, I also managed to reproduce the bug by using the arrow keys on the keyboard. While testing to see if the bug occurs when using the arrow keys, I managed to make the bug occur in both current -> prev and current -> next ways, even at a moderate pace of pressing the keys.

@U-alb
Copy link
Contributor

U-alb commented Apr 8, 2024

For me, the bug manifests either by what my colleague described or, more often, by getting a visual glitch that consists in multiple slides being over-layered

That is on Kali 2024.1 (Mercury browser) and Windows 11 build 22631 (Firefox browser)

Screenshot 2024-04-08 150057

@alexandruradovici
Copy link
Contributor

I think this might be a browser problem.

@alexandruradovici
Copy link
Contributor

alexandruradovici commented May 5, 2024

Maybe it's worth submitting a bug to slide directly https://github.com/slidevjs/slidev, it seems to be a framework problem. Please mention the issue here after opening it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants