UPBGE: Add an option to use viewport render directly in embedded #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of custom game engine render loop. Advantages: We can use all render options, modes (solid, wireframe...), things like grease pencil which are not drawn in game loop. We can hide outlines/overlays as there is a viewport option. Inconvenients: Less flexibility if we want to do other things in the draw pipeline. But this is cool as an option I believe. TODOs: - See if we can get a valid ARegion/maybe other things... to use this render mode in blenderplayer? Or we keep this option only for embedded and lock it for blenderplayer. - Fix the mess introduced in KX_BlenderMaterial. and... I don't remember what
lordloki
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not perfect, but I think it can be merged. This is really fun.
Maybe we should avoid the beginning of the render loop in KX_KetsjiEngine and move the code here
to render only the main scene and the main camera.
But as an experimental option it's cool