UPBGE: Replace WITH_PYTHON_SECURITY by WITH_GAMEENGINE_SECURITY in La…

…uncher/.

WITH_PYTHON_SECURITY was previously used to disable the python console and
the main loop override from blenderplayer. This was not the best way as
WITH_PYTHON_SECURITY is enabled by default. To fix this behaviour a specific
cmake option is added : WITH_GAMEENGINE_SECURITY.

CMakeLists.txt

@@ -229,6 +229,10 @@ option(WITH_BULLET        "Enable Bullet (Physics Engine)" ON)
 option(WITH_SYSTEM_BULLET "Use the systems bullet library (currently unsupported due to missing features in upstream!)" )
 mark_as_advanced(WITH_SYSTEM_BULLET)
 option(WITH_GAMEENGINE    "Enable Game Engine" ${_init_GAMEENGINE})
+
+option(WITH_GAMEENGINE_SECURITY "Disable game engine python debugging tools" OFF)
+mark_as_advanced(WITH_GAMEENGINE_SECURITY)
+
 if(APPLE)
 	set(WITH_GAMEENGINE_DECKLINK OFF)
 else()

source/gameengine/Launcher/CMakeLists.txt

@@ -65,8 +65,8 @@ set(SRC
 	LA_System.h
 )
 
-if(WITH_PYTHON_SECURITY)
-	add_definitions(-DWITH_PYTHON_SECURITY)
+if(WITH_GAMEENGINE_SECURITY)
+	add_definitions(-DWITH_GAMEENGINE_SECURITY)
 endif()
 
 if(WITH_AUDASPACE)

source/gameengine/Launcher/LA_Launcher.cpp

@@ -362,7 +362,7 @@ void LA_Launcher::ExitEngine()
 
 void LA_Launcher::HandlePythonConsole()
 {
-#ifndef WITH_PYTHON_SECURITY
+#ifndef WITH_GAMEENGINE_SECURITY
 	if (!m_pythonConsole.use) {
 		return;
 	}

source/gameengine/Launcher/LA_PlayerLauncher.cpp

@@ -289,7 +289,7 @@ void LA_PlayerLauncher::startFullScreen(
 
 bool LA_PlayerLauncher::GetMainLoopPythonCode(char **pythonCode, char **pythonFileName)
 {
-#ifndef WITH_PYTHON_SECURITY
+#ifndef WITH_GAMEENGINE_SECURITY
 	if (m_pythonMainLoop) {
 		if (BLI_is_file(m_pythonMainLoop)) {
 			size_t filesize = 0;