UPBGE: Prevent mipmapping while setting VideoFFmpeg #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
up to date with master 03/03/2017
youle31
changed the title
panzergame
added a commit
that referenced
this pull request
Mar 6, 2017
In IMB_allocFromBuffer a copy of the image data is proceeded with a call to MEM_dupallocN. But all the MEM_ prefix functions work with memory allocated with the same function. This was not the case in Image::init, so the copy failed and the all the operations later used to mipmap were invalid and raise segmentation faults. To fix this issue we use MEM_mallocN in Image::init. Fix issue #411.
|
Fixed in 9c5581b Thanks panzergame 👍 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up to date with master 03/03/2017
Bug only on Windows.
See comments on old branch (old pull request)