Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPBGE: Cleanup UI. #772

Merged
merged 1 commit into from
Sep 1, 2018
Merged

UPBGE: Cleanup UI. #772

merged 1 commit into from
Sep 1, 2018

Conversation

panzergame
Copy link
Contributor

Some unused options/entities are removed from the UI in game engine mode:

  • scene keying set
  • scene audio
  • speaker and forec filed in add menu

Also the game engine is renamed UPBGE.

Fix issue #756.

Copy link
Collaborator

@UnidayStudio UnidayStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes. But I'd like to point again that instead of removing the sound speaker, it's a good point to make them actually works. This is a redundant design decision (since we can archieve the same result by simple adding a logic to a normal object). And there are seveal different opinions about redundancy in design, but this is a good point:

"A Designed Redundancy can be a powerful mechanism to enhance the speed, discoverability, and learnability of your products. In some cases ... ... they can be a core component of how your product delivers an experience."

Font: https://uxdesign.cc/designed-redundancies-ux-patterns-to-unblock-frustration-and-save-lives-1f077aaa1c03

I'd like to point that a speaker is much more intuitive to the new user to be a "sound reproducer".It will increase the discoverabilty of these feature (sound) in the engine. And, of couse, even for the experienced user, having a GameObject that is alrady prepared to reproduce sounds, without any other configuration, will increase the development speed.

@paul-marechal
Copy link
Collaborator

I'd like to point that a speaker is much more intuitive to the new user to be a "sound reproducer".It will increase the discoverabilty of these feature (sound) in the engine. And, of couse, even for the experienced user, having a GameObject that is alrady prepared to reproduce sounds, without any other configuration, will increase the development speed.

That's an issue on its own that deserves its own PR. Better remove the item from the UI until it has an actual purpose.

@youle31
Copy link
Collaborator

youle31 commented Aug 7, 2018

I agree with this patch and I agree both with @UnidayStudio and @marechal-p remarks

@UnidayStudio
Copy link
Collaborator

We can remove Area lights as well

@panzergame
Copy link
Contributor Author

I can't remove AREA in the lamp type enum because the front end UI doesn't provide a way to filter enum properties.
Otherwise it possible to replace the UI of area lamp by a message like 'not supported in game engine'.

@panzergame
Copy link
Contributor Author

panzergame commented Aug 30, 2018

@lordloki : The function using these variables is:

void BKE_sound_update_scene_listener(struct Scene *scene)
{
	AUD_Sequence_setSpeedOfSound(scene->sound_scene, scene->audio.speed_of_sound);
	AUD_Sequence_setDopplerFactor(scene->sound_scene, scene->audio.doppler_factor);
	AUD_Sequence_setDistanceModel(scene->sound_scene, scene->audio.distance_model);
}

Though it is using scene->sound_scene which doesn't seem global or registered to a global variable and also not used by the game engine. The type of AUD_Sound is also strange.

I didn't do a deep research, @lordloki : Do you have a example of these values used in game ?

@lordloki
Copy link
Member

@panzergame : In void LA_Launcher::InitEngine() you also have:

#ifdef WITH_AUDASPACE
	// Initialize 3D Audio Settings.
	AUD_Device *device = BKE_sound_get_device();
	AUD_Device_setSpeedOfSound(device, m_startScene->audio.speed_of_sound);
	AUD_Device_setDopplerFactor(device, m_startScene->audio.doppler_factor);
	AUD_Device_setDistanceModel(device, AUD_DistanceModel(m_startScene->audio.distance_model));
#endif  // WITH_AUDASPACE

@panzergame
Copy link
Contributor Author

@lordloki : These attributes are now exposed.

@lordloki
Copy link
Member

@panzergame I have a issue with audio panel when revert to other render from UPBGE.

Fix plus cosmetic refactor: https://gist.github.com/lordloki/a34ef600e1255f4b93d087eaaf7505e9

@panzergame
Copy link
Contributor Author

The audio panel is now:

screenshot_20180901_132431

Copy link
Member

@lordloki lordloki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

Some unused options/entities are removed from the UI in game engine mode:
- scene keying set
- speaker and force field in add menu

The game engine is renamed UPBGE and the audio panel under scene tab is siplified
to expose only the speed of sound, doppler factor and the distance model, these
attributes are used by LA_Launcher to initialize the AUD_Device.

Fix issue #756.
@panzergame panzergame merged commit 6065fbd into master Sep 1, 2018
@panzergame panzergame deleted the ge_ui branch October 6, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants