Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPBGE: Rename async parameter from LibLoad as is a reserved word #827

Merged
merged 2 commits into from
Sep 9, 2018

Conversation

lordloki
Copy link
Member

@lordloki lordloki commented Sep 9, 2018

async is a reserved word in Pyhon 3.7
Check: https://docs.python.org/3.7/whatsnew/3.7.html#summary-release-highlights

This Fix #826 .

The python rst modification should be commited here and UPBGE-Docs repository or only here or only there?

@panzergame
Copy link
Contributor

The UPBGE-Docs rst (for API) is a copy of the one in main repo.

@panzergame
Copy link
Contributor

I think that's asynchronous instead of asyncronous.

@lordloki lordloki merged commit 1959ed2 into master Sep 9, 2018
@lordloki lordloki deleted the ge_python37_async branch September 24, 2018 06:58
youle31 pushed a commit that referenced this pull request May 26, 2019
Rename async parameter from LibLoad as is a reserved word in Python 3.7

A note will be included in Release notes as this breaks compatibility with old scripts.
lordloki added a commit that referenced this pull request Dec 28, 2019
Rename async parameter from LibLoad as is a reserved word in Python 3.7

A note will be included in Release notes as this breaks compatibility
with old scripts.

NOTE by lordloki: I added this commit in a first place to try recovering
LibLoad and LOD features.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants