Dockerfile for dockerize application #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ep, aixo no funcionarà perque el mailtoticket encara no està passat a python 3 (#187) . Potser primer s'hauria de provar amb python 2.7 i llavors fer els canvis. |
Ya lohe pasado a version 2.7, pero no se como probarlo.... se te ocurre como probarlo? |
aaguilera
reviewed
Nov 11, 2019
alexm
requested changes
Nov 20, 2019
alexm
reviewed
Jun 26, 2020
alexm
reviewed
Jun 26, 2020
Evita que copiem a la imatge docker el directori recomanat al README per als virtualenv.
No cal modificar el PATH perquè no hi ha cap virtualenv.
Amb el suport per LDAP cal tenir instal·lades algunes llibreries addicionals.
Enlloc de guardar dins la imatge la configuració de la instància és preferible muntar-la com un volum.
alexm
reviewed
Jun 26, 2020
Altrament la instal·lació de les dependències no es pot desar a la cache de les imatges perquè la còpia invalida tot el que vingui després.
alexm
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firts version