Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FITAPurchaseReporter sendReport error incorrectly annotated as nonnull #3

Closed
bobergj opened this issue Jan 26, 2018 · 1 comment
Closed

FITAPurchaseReporter sendReport error incorrectly annotated as nonnull #3

bobergj opened this issue Jan 26, 2018 · 1 comment
Assignees
@tjelen

Comments

@bobergj
Copy link

bobergj commented Jan 26, 2018

In Swift the generated interface becomes:

open func send(_ report: FITAPurchaseReport, done: ((Error) -> Swift.Void)? = nil) -> Bool

So one cannot check if the error is nil.
@bobergj
Copy link
Author

bobergj commented Jan 26, 2018

Btw, the parameter name "completionHandler" is the platform convention for what you call "done".

@tjelen tjelen self-assigned this Feb 13, 2018
tjelen added a commit that referenced this issue Feb 20, 2018
@tjelen
Add nullable to sendReport completion handler error argument #3
1a65838
@tjelen tjelen closed this as completed Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjelen tjelen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobergj @tjelen