Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prod Data Passenger Details | not sorting itinerary table ETD properly #479

Closed
dje04001 opened this issue Jun 23, 2017 · 4 comments
Closed

Prod Data Passenger Details | not sorting itinerary table ETD properly #479

dje04001 opened this issue Jun 23, 2017 · 4 comments
Assignees
@donleyac
Labels
bug
Milestone
Complete PNR Tab

Comments

@dje04001
Copy link
Contributor

dje04001 commented Jun 23, 2017 •
edited

No description provided.

@dje04001 dje04001 added this to the Sprint 5 (7/5 - 7/19) milestone Jun 23, 2017
@dje04001 dje04001 added the bug label Jul 11, 2017
@dje04001 dje04001 modified the milestones: Common Framework Branch, Sprint 5 (7/5 - 7/12) Jul 12, 2017
@donleyac
Copy link
Collaborator

donleyac commented Aug 1, 2017

Should be working, we need to test.

@dje04001
Copy link
Contributor Author

dje04001 commented Aug 3, 2017

sorting is in reverse order

donleyac added a commit that referenced this issue Aug 7, 2017
@donleyac
UI Tweaks
0acfe59 
Targeted the following tickets:
#555 #553 #563 #557 #554  #411
#479 - normal order now

#552 - partial only ui
@dje04001 dje04001 closed this as completed Aug 8, 2017
@dje04001
Copy link
Contributor Author

dje04001 commented Aug 8, 2017

sorting is alphabetical vs. value driven. 2016-11-26 04:18 PM is displayed before 2016-11-26 07:35 AM.

@dje04001 dje04001 reopened this Aug 8, 2017
@donleyac
Copy link
Collaborator

donleyac commented Aug 8, 2017

From the frontend perspective it is fine, once we convert all the dates to military time in the backend this sorting type would provide the expected order. Right now it's doing this because the date is being managed as a string and alphabetical is the only sorting for that.

@dje04001 dje04001 closed this as completed Aug 9, 2017
@dje04001 dje04001 removed the 4 - Done label Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donleyac donleyac

Labels
bug
Projects
None yet
Milestone
Complete PNR Tab
Development

No branches or pull requests
3 participants
@donleyac @tjwdev @dje04001