Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in large-flows.py decoder #51

Closed
slinkard opened this issue May 19, 2015 · 2 comments
Closed

Bug in large-flows.py decoder #51

slinkard opened this issue May 19, 2015 · 2 comments

Comments

@slinkard
Copy link

The large-flows.py decoder appears to have a bug in the code in line 24. The decoder is designed for flows 1MB or larger. This would 1048576 bytes. Line 24 incorrectly omits the last digit:

self.min = 104857 * self.size

should be

self.min = 1048576 * self.size
@wglodek
Copy link
Contributor

wglodek commented May 19, 2015

@slinkard Thanks! Fixed in 80ad7a3. The developer responsible for this bug has been promoted to middle management and should no longer be a problem.

@dek443
Copy link
Contributor

dek443 commented Oct 8, 2020

The Python 2 version of Dshell is now deprecated and frozen as Release v2.4.10. We are closing all Pull Requests and Issues associated with that version, as Dshell development has shifted to the current version for Python 3. Thank you for your support.

@dek443 dek443 closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wglodek @slinkard @dek443