Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in its current state, the config parser would reject empty lines and comments that do not include a '=' character as syntax errors, since the check for '=' happens before the check for the comment indicator.
I fixed that.
Also, I saw a small bug possibility in that the parser never trimmed the whitespace of the value section of the key=value pair, so key= value would've resulted in value being " value". I could not imagine a scenario in which this might be wanted or useful, so i added a trim() for that.
I'm using the master branch on my desktop machines since there still is no 4.13 compatible release.