Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with-connect-type to dbus signals #356

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

muelli
Copy link
Contributor

@muelli muelli commented Jan 16, 2020

This also adds with-connect-type to the documentation.

#354
#340

CCing @gwinkenbach as the author of with-connect-type in #274

This change allows consumers to enjoy a structured view onto the
connect-type property.
This should make reading the documentation a bit more useful by
mentioning what the stringified values can be.
@RyuzakiKK
Copy link
Contributor

I confirm that it is working as expected.
This is an example of the DevicePresenceChanged signal:

signal time=1579273753.855402 sender=:1.4447 -> destination=(null destination) serial=8 path=/org/usbguard1/Devices; interface=org.usbguard.Devices1; member=DevicePresenceChanged
   uint32 45
   uint32 3
   uint32 0
   string "allow id 0951:1642 serial "001CC870C25E4" name "DT 101 G2" hash "sVYzXusl2fPrdgo2qy" parent-hash "vawpCqjGEnZlurUwVcF9" via-port "3-1" with-interface 08:06:50 with-connect-type "hotplug""
   array [
      dict entry(
         string "hash"
         string "sVYzXusl2fPrdgo2qy"
      )
      dict entry(
         string "id"
         string "0951:1642"
      )
      dict entry(
         string "name"
         string "DT 101 G2"
      )
      dict entry(
         string "parent-hash"
         string "vawpCqjGEnZlurUwVcF9O"
      )
      dict entry(
         string "serial"
         string "001CC0EC3"
      )
      dict entry(
         string "via-port"
         string "3-1"
      )
      dict entry(
         string "with-interface"
         string "08:06:50"
      )
      dict entry(
         string "with-connect-type"
         string "hotplug"
      )
   ]

@radosroka radosroka merged commit 56f6fa9 into USBGuard:master Feb 11, 2020
@radosroka
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants