Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken run script #219

Closed
buggtb opened this issue Mar 10, 2021 · 4 comments
Closed

Broken run script #219

buggtb opened this issue Mar 10, 2021 · 4 comments
Assignees

Comments

@buggtb
Copy link
Collaborator

buggtb commented Mar 10, 2021

Hey @nhandyal / @lewismc

801f1ae#diff-ba9a32629fea83dfb633800ea410676e10fc6d41d8cbef7401f0e437dc5fa6ddR12

That change is breaking to the run script for anyone (like myself) who moves the build out of a build directory

@lewismc
Copy link
Member

lewismc commented Mar 10, 2021

Hi @buggtb we discussed this today. The team are working on a fix.

@lewismc
Copy link
Member

lewismc commented Mar 21, 2021

@nhandyal @felixloesing @kyan2601 @KilometersFan who is working on fixing this?

@nhandyal
Copy link
Contributor

Hey @buggtb thanks for reporting and your patience while we resolved this. Here's a PR that addresses this: #223 . I'm not sure how your setup is configured, so can you let me know if this resolves the issue for you. I think it should as the fix in the PR first tries to resolve the JAR path using relative paths (how things worked to begin with), then tries the absolute path (how we changed it to be).

@buggtb
Copy link
Collaborator Author

buggtb commented Mar 25, 2021 via email

@buggtb buggtb closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants