169 numpy #187
Merged
169 numpy #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces. Added a level test to see if they are close with np.allclose()
… whether or not cython is installed
|
Added Cython |
scotthavens
commented
Sep 17, 2020
Hedrick-ARS
reviewed
Sep 17, 2020
jomey
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 2 part PR.
Numpy version
Numpy > v1.19 made some underlying changes that made the vapor pressure calculation slightly different only from HRRR. Looking at the vapor pressure calculation, the air temperature and relative humidity were exactly the same. The differences in vapor pressure stem from the
satiandsatwwith differences in the float tolerance range.Added a few levels of tests. First still tests for exact match. If the arrays are not exact, then try
allclosewith relative tolerance of 1e-5 and 1e-4. Raise an exception if these are not met.SMRF pip install
The setup.py imports numpy which will not work if numpy is not installed. Following steps here, moved the build_ext to a class so numpy is only imported if compiling the pyx files to C.
This does move away from using Cython build_ext but not fully sure that it is needed as setuptools will call gcc to compile.