Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind ninja interpolation #196

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Wind ninja interpolation #196

merged 3 commits into from
Nov 3, 2020

Conversation

scotthavens
Copy link
Contributor

@scotthavens scotthavens commented Nov 2, 2020

If there are no nan values in the WindNinja data, don't interpolate. An error occurred when the topo resolution is the same resolution as WindNinja where there are no NaN value and an exception is raised in scipy.

Copy link
Collaborator

@jomey jomey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is time, I would add a couple of unit tests around this. Seems straight forward to test

@scotthavens
Copy link
Contributor Author

If there is time, I would add a couple of unit tests around this. Seems straight forward to test

I have a file now that is 50m for the Lakes, I'll add the test.

@jomey
Copy link
Collaborator

jomey commented Nov 3, 2020

If there is time, I would add a couple of unit tests around this. Seems straight forward to test

I have a file now that is 50m for the Lakes, I'll add the test.

Cool.
Some times I also just use numpy.random to test some basic logic around manipulating array data. Think this could work for this case too, no?

@scotthavens
Copy link
Contributor Author

Added a test with 50m WindNinja output. The implicit test is that there is no exception which was happening with the 50m output.

@scotthavens scotthavens merged commit 36d2c16 into master Nov 3, 2020
@scotthavens scotthavens deleted the wind_ninja_interp branch November 3, 2020 19:39
jomey referenced this pull request in UofU-Cryosphere/smrf Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants