Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit Spacing and Sizing System #496

Closed
Tracked by #522
francisrupert opened this issue Jun 17, 2021 · 0 comments
Closed
Tracked by #522

Audit Spacing and Sizing System #496

francisrupert opened this issue Jun 17, 2021 · 0 comments
Assignees
@francisrupert
Labels
element: base P3 source: internal FBCSS type: design
Milestone
2.7.0

Comments

@francisrupert
Copy link
Contributor

francisrupert commented Jun 17, 2021 •
edited
Loading

Evaluate all fsa-style parts for compliance with 4x4 base unit. Ensure updates have not strayed too much, and log issues for potential updates.

Related: #495, #494
@francisrupert francisrupert added this to the 2.6.0 milestone Jun 17, 2021
@francisrupert francisrupert self-assigned this Jun 17, 2021
@francisrupert francisrupert added this to Do in Design System: 2.6.0 / 1.18.x via automation Jun 17, 2021
francisrupert added a commit that referenced this issue Jun 17, 2021
@francisrupert
Initial #496, #495, #494
eec1c56
francisrupert added a commit that referenced this issue Jun 17, 2021
@francisrupert
fsa-field spacing [amends #496]
81640b5
francisrupert added a commit that referenced this issue Jun 17, 2021
@francisrupert
Kithen Sink spacing [amends #496]
6f3756c
francisrupert added a commit that referenced this issue Jun 21, 2021
@francisrupert
[amends #496]
149fd72
@francisrupert francisrupert modified the milestones: 2.6.0, The Fridge Jun 24, 2021
@francisrupert francisrupert changed the title Audit for 4x4 Audit Spacing Compliance Aug 18, 2021
@francisrupert francisrupert mentioned this issue Aug 18, 2021
Closed
francisrupert added a commit that referenced this issue Nov 17, 2021
@francisrupert
Updated typography line-height to fit 4 baseline grid [amends #496]
82e7983
francisrupert added a commit that referenced this issue Nov 17, 2021
@francisrupert
Updated margins (intial) [amends #496, #495]
7f89feb
@francisrupert francisrupert mentioned this issue Nov 17, 2021
Closed
@francisrupert francisrupert modified the milestones: The Fridge, 2.6.1 Nov 17, 2021
francisrupert added a commit that referenced this issue Nov 17, 2021
@francisrupert
Refactoring margin/padding properties to align to sizing system [amends
d3f0d90 
#496, #495]
francisrupert added a commit that referenced this issue Nov 17, 2021
@francisrupert
Refactoring margin/padding properties to align to sizing system [amends
20b8309 
#496, #495]
francisrupert added a commit that referenced this issue Nov 18, 2021
@francisrupert
Refactoring margin/padding properties to align to sizing system [amends
3a702bf 
#496, #495]
francisrupert added a commit that referenced this issue Nov 18, 2021
@francisrupert
Refactoring margin/padding properties to align to sizing system [amends
133fdc6 
#496, #495]
This was referenced Nov 18, 2021
Closed
Closed
@francisrupert francisrupert changed the title Audit Spacing Compliance Audit Spacing and Sizing System Nov 19, 2021
@francisrupert francisrupert mentioned this issue Nov 19, 2021
Closed
This was referenced Nov 23, 2021
Closed
Closed
Closed
Closed
Closed
@francisrupert francisrupert modified the milestones: 2.7.0-RC1, 2.7.0 Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francisrupert francisrupert

Labels
element: base P3 source: internal FBCSS type: design
Projects
No open projects
Design System: 2.7.0 / 1.19.0
Status: Done
Milestone
2.7.0
Development

No branches or pull requests
1 participant
@francisrupert