Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a bug in creating u and v components #188

Closed
wants to merge 1 commit into from

Conversation

dwongepa
Copy link
Contributor

On branch update_54

Contact:
David Wong US EPA

Type of code change:
bug fix

Description of changes:

Fixed a bug in creating u and v components by removing the following two lines

metcro3d_data_wrf (:,:,1:nlays,15) = zf (:,:,1:nlays)
metcro3d_data_wrf (:,:,1:nlays,16) = zf (:,:,1:nlays)

which overwrote the proper calculations:

metcro3d_data_wrf (c,r,kk,15) = grid%u_phy(ii,kk,jj) ! store u wind component on mass point
metcro3d_data_wrf (c,r,kk,16) = grid%v_phy(ii,kk,jj) ! store v wind component on mass point

Issue:
N/A

Summary of Impact:
Wind u and v components were incorrectly represented by level high. In turns it impacted the wind speed calculation as well as the plume rise calculation.

Tests conducted:
A one day test was conducted based on the NE 2018 Benchmark dataset. Here are some snapshot of the difference (new - old) with respect to four variables: O3, ASO4J, SWDOWN, and T2.

2018_07_01_o3

2018_07_01_aso4j

2018_07_01_swdown

2018_07_01_t2

@kmfoley
Copy link
Collaborator

kmfoley commented Apr 28, 2023

Closing this PR as this bugfix should be targeted for the 5.4+ branch rather than the main branch.

@kmfoley kmfoley closed this Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants