fixed a bug in creating u and v components #188
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On branch update_54
Contact:
David Wong US EPA
Type of code change:
bug fix
Description of changes:
Fixed a bug in creating u and v components by removing the following two lines
metcro3d_data_wrf (:,:,1:nlays,15) = zf (:,:,1:nlays)
metcro3d_data_wrf (:,:,1:nlays,16) = zf (:,:,1:nlays)
which overwrote the proper calculations:
metcro3d_data_wrf (c,r,kk,15) = grid%u_phy(ii,kk,jj) ! store u wind component on mass point
metcro3d_data_wrf (c,r,kk,16) = grid%v_phy(ii,kk,jj) ! store v wind component on mass point
Issue:
N/A
Summary of Impact:
Wind u and v components were incorrectly represented by level high. In turns it impacted the wind speed calculation as well as the plume rise calculation.
Tests conducted:
A one day test was conducted based on the NE 2018 Benchmark dataset. Here are some snapshot of the difference (new - old) with respect to four variables: O3, ASO4J, SWDOWN, and T2.