Update config_cmaq.csh #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix as per issue reported here: USEPA#199
kmfoley
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Thank you @lizadams for bringing this typo fix into the repo. The source code for the main branch is frozen but it makes sense to get this config script updated now. If you could please do a second PR to the 5.4+ branch so that it is not behind main. We will also get this ported over to our internal research branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix as per issue reported here: #199
Contact:
Liz Adams
Type of code change:
minor typo in config_cmaq.csh
Description of changes:
Clear and concise description of the problem, solution, and required changes.
Issue:
If this resolves a known issue, include the link to the GitHub Issue number.
Summary of Impact:
Please state whether this update changes the results of the core model predictions in terms of concentration, deposition, etc.
Please state the approximate impact this update has on model runtime, if any.
Tests conducted:
Describe tests that were conducted including domain and time period (e.g. BLDCHECK; June 1-2 2016 SEBENCH; Jan 2017 12US1) and results of the tests. Include plots of relevant results.