Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diesel-only NR runs with imported fuels produces no output #6

Closed
danielbizercox opened this issue Jan 7, 2021 · 1 comment
Closed
Labels
bug Something isn't working
Milestone

Comments

@danielbizercox
Copy link
Collaborator

danielbizercox commented Jan 7, 2021

If you do a diesel-only nonroad run with imported fuels (i.e., you select only diesel equipment, and then you create a NR input database, export the default fuels, and then re-import them), you will get an error about RVP being out of range and you won't get output.

@danielbizercox danielbizercox added this to the v3.0.1 milestone Jan 7, 2021
@danielbizercox
Copy link
Collaborator Author

A workaround for this issue until we release MOVES3.0.1 is to import a gasoline fuel supply and fuel formulations, even though they should not be used for your diesel-only run. To do so, add a gasoline equipment sector to your RunSpecand export the default fuels. Include the gasoline rows in both the fuel supply and the fuel formulations when you import the fuels data. After importing and getting a green check, you can remove the gasoline equipment from the RunSpec.

danielbizercox added a commit that referenced this issue Jan 21, 2021
For the NR LF/AvgHP: The Go calculator is implicitly splitting both emissions and activity by fuelSubTypeID when that output is requested by the user. The issue is that the LF and AvgHP activity values shouldn't be split, but should be duplicated. Since it is happening implicitly in the Go calculator, we decided to simply recombine the LF and AvgHP values as soon as the Go calculator results are loaded by the Java, instead of adding a separate edge case in the Go.

For NR diesel-only runs: When the user exports the default fuels, it only includes fuel types selected in the runspec. So when these fuels are reimported, there are no rows about gasoline. Unlike other tables, the nrfuelsupply table completely overwrites the default table (instead of being combined with the default table), so at runtime, there is no gasoline information. When the Java code is setting up the NR Fortran inputs, it doesn't have gasoline information, so it supplies 0 RVP. When the Fortran starts, it performs a validity check on the inputs, including valid RVP values (regardless if they will be used or not), and it quits when it sees an RVP of 0. The solution is to provide the Fortran with the default fuelFormulationID 10 RVP and sulfur levels when no gasoline values can be found. A warning is emitted when this occurs, so the user is aware and can make changes if this is unintentional.
@danielbizercox danielbizercox added the bug Something isn't working label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant