Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INABILITY TO READ IN OBERLIN NETWORK USING WNTR #348

Closed
uthmankareem opened this issue Apr 29, 2023 · 6 comments
Closed

INABILITY TO READ IN OBERLIN NETWORK USING WNTR #348

uthmankareem opened this issue Apr 29, 2023 · 6 comments
Labels

Comments

@uthmankareem
Copy link

Summary
Describe your question.
I am trying to read in an inp file for oberlin network on python jupyter. I have used the same command to read in modena network and it worked. However, when I try to read in oberlin network, it gives attribute error: None type has no attribute 'factor'

Attached is the error screenshot.
error1
error2

Thank you.

Environment
[Optional] Provide information on your computing environment.

  • Operating system: Windows OS 10
  • Python version:
  • WNTR version: 2.2
@kaklise
Copy link
Collaborator

kaklise commented May 1, 2023

Does the INP file include flow units (i.e. GPM)? EPANET might assume default units, but it looks like WNTR requires that field. One way to populate the INP file with default values is to load the file into the EPANET GUI and resave the file.

@dbhart it would be helpful to update io.py to catch this issue before flow_units is used elsewhere.

@uthmankareem
Copy link
Author

uthmankareem commented May 1, 2023 via email

@kaklise
Copy link
Collaborator

kaklise commented May 2, 2023

That is correct, loading the INP file into the EPANET GUI, then saving it under a new name should add the missing default entries. The comment about io.py was for one of our developers.

@uthmankareem
Copy link
Author

uthmankareem commented May 2, 2023 via email

@dbhart
Copy link
Collaborator

dbhart commented May 3, 2023

Does the INP file include flow units (i.e. GPM)? EPANET might assume default units, but it looks like WNTR requires that field. One way to populate the INP file with default values is to load the file into the EPANET GUI and resave the file.

@dbhart it would be helpful to update io.py to catch this issue before flow_units is used elsewhere.

Yes, it would, I will try to catch that.

@kaklise kaklise closed this as completed Jun 9, 2023
@kaklise kaklise added the support label Jun 9, 2023
@uthmankareem
Copy link
Author

uthmankareem commented Jun 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants