New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding vertices to morph.node #332
Conversation
Updates related to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for catching the issue in the epanet io test!
Provide a summary of the proposed changes, describe tests and documentation, and review the acknowledgement below.
Summary
This PR resolves issue #283 by including link vertices in the transformations performed on node coordinates.
Tests and documentation
No new features were added, but new lines have been added to existing tests to cover vertex cases.
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.