Valve test bug #344
Merged
Valve test bug #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trying old coverage command
restoring coverage command to previous state
…ap, dataframe indexing with sets, and dataframe squeezing. fire_flow_demo simulation results are not matching the saved data for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a testing bug that occurs in
test_network_layers.py. The error was only occurring for python 3.10. I believe the issue was caused by a subtle change in how the pandas version used in 3.10 handles empty dataframes. In the WNTR test, two empty dataframes are compared, but their index dtypes are different. Even though they are empty, this raises an assertion error.I fixed this issue by adding the option to not check index dtype when comparing the DataFrames.