Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow and testing fixes #430

Merged
merged 17 commits into from
Jun 18, 2024
Merged

Workflow and testing fixes #430

merged 17 commits into from
Jun 18, 2024

Conversation

kbonney
Copy link
Collaborator

@kbonney kbonney commented Jun 18, 2024

Summary

  • Adding a restriction on numpy dependency to be less than 2.0 (AML is not 2.0 compatible yet).
  • Changing the macOS version we use in workflow from macOS-latest to macOS-13 because tests fail on ARM due to a lack of EPANET binaries for this architecture.
  • Addressed a testing error that occurs on Python 3.12.4. The behavior of a private variable for enums appears to have changed, so we can no longer use all uppercase or all lowercase versions of member names to access members from an enum.
  • Changed fail-fast to false in multiple jobs in the build workflow. This means that jobs will continue running even when one fails.

Tests and documentation

None added.

Acknowledgement

By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.

@kaklise kaklise self-requested a review June 18, 2024 18:13
@kaklise kaklise merged commit e74e9df into USEPA:main Jun 18, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants