Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address validation schema #111

Closed
Tracked by #106
dpgraham4401 opened this issue Sep 26, 2022 · 2 comments
Closed
Tracked by #106

Address validation schema #111

dpgraham4401 opened this issue Sep 26, 2022 · 2 comments
Labels
client Related to front end workings (React/Redux) enhancement New feature or enhancement

Comments

@dpgraham4401
Copy link
Member

No description provided.

@saheersk
Copy link

May I know what all validation do want can you brief it?

@dpgraham4401
Copy link
Member Author

Hey @saheersk, apologies for the slow response.

Happy you're interested in contributing, I'm part way through working on this one, sorry I haven't been keeping up the issue board while i'm on detail. I may just push what I've got and if you see improvement, you're welcome to submit something.

I can also go through and add a couple issues that may be more first time contributor friendly (with a better description ha). You can ping me on any of those issue and i can send it your way.

With regard to Address validation, we have a JSON schema for reference from the e-Manifest GitHub repo. The hazardous waste manifest has a Site Address and Mailing Address each has the meet the requirements when submitting. Meeting those covers about 90% of what needs to be done (not just for the Address but most of the rest of the Manifest model). Outside of that, if you think of other validations that can be applied to addresses, we have to be careful because we'll be pulling down manifests from the e-Manifest API that uses these validations as well and the data quality is not the best.

I have Manifest TypeScript interface defined in the branch I've been holding on to for too long.

@dpgraham4401 dpgraham4401 added enhancement New feature or enhancement client Related to front end workings (React/Redux) labels Nov 2, 2022
@dpgraham4401 dpgraham4401 changed the title address form validation Address validation schema Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Related to front end workings (React/Redux) enhancement New feature or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants