Deleting the contributor from an article should also delete the person-org relationship

[amruelama]

Deleting the contributor (person related to org) from an article should also delete the author-org relationship and shouldn't have an empty organization listed under the person (see below):

[lomky]

Found the root of this problem. The delete path only deletes the relationship between the Publication and the Contributor, but doesn't remove the Contributor.

To fix this, we should check if there are any remaining publications linked to this Contributor, and if not, delete the Contributor object. (Person & Org objects being unaffected).

[lomky]

Code of interest is in lib/Tuba/Controller.pm in the method update_contributors

[amruelama]

Solving this issue will also solve the future additions/deletions that may lead to #357

[lomky]

Okay, changes made.

• Deleting one of many relationships does not remove the contributor - publication map
• Deleteing the only relationship does remove the map
• deleting the map is now properly audited

1 hour ago before code change
14 minutes ago after code change

[lomky]

@amruelama I have this running on the data-review instance. Could you please test it there and confirm it is working as you expect?

[amruelama]

Tested for a couple articles and it works well! @lomky