Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'publisher' field on journal #553

Closed
amruelama opened this issue Aug 8, 2017 · 5 comments
Closed

Deprecate 'publisher' field on journal #553

amruelama opened this issue Aug 8, 2017 · 5 comments

Comments

@amruelama
Copy link
Member

As we have added 'publisher' as a contributor (#548) for all the journals in GCIS, we need to remove 'publisher' field. Downloaded backup.

@lomky lomky added this to the Next Release milestone Aug 9, 2017
@lomky lomky changed the title Remove 'publisher' field from journal Deprecate 'publisher' field on journal Aug 9, 2017
@lomky
Copy link
Collaborator

lomky commented Aug 9, 2017

Deprecating rather than removing, to avoid breaking tools.

GUI will no longer offer up the field.

lomky added a commit that referenced this issue Aug 9, 2017
@lomky
Copy link
Collaborator

lomky commented Aug 9, 2017

@amruelama this is live on data-dev for your review.

@amruelama
Copy link
Member Author

Looks perfect on dev!

@amruelama
Copy link
Member Author

@lomky Reopening this issue because, even though the 'publisher' field is deprecated and the data is removed, the related data is still available when downloaded as csv, json and other formats. Is it possible to either remove the data completely or add the relevant publisher in the downloadable data? We did a clean-up before deprecating the field and relating the relevant org as 'publisher'. We also populated missing publishers as a part of (#548)

@lomky
Copy link
Collaborator

lomky commented Aug 10, 2018

Change done on stage @amruelama.

@lomky lomky closed this as completed Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants