Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No warning/error if no targetname passed to to_controlnetwork #126

Closed
ladoramkershner opened this issue Jun 26, 2019 · 0 comments · Fixed by #167
Closed

No warning/error if no targetname passed to to_controlnetwork #126

ladoramkershner opened this issue Jun 26, 2019 · 0 comments · Fixed by #167
Assignees
@jlaura
Labels
good first issue

Comments

@ladoramkershner
Copy link
Contributor

If no target name is in autocnet and a controlnetwork is output (using plio, however that is done) it will set the TargetName in the control network to 'None'. Should raise a warning or error instead.

Group = ControlNetworkInfo
NetworkId = None
TargetName = None
UserName = None
Created = "2019-06-25 19:13:25"
LastModified = "2019-06-25 19:13:25"
Description = None
NumberOfPoints = 263
NumberOfMeasures = 1359
Version = 2
End_Group
@jlaura jlaura self-assigned this Nov 11, 2021
@jlaura jlaura linked a pull request Nov 12, 2021 that will close this issue
Fixes 126 and PVL grammar issue #167
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlaura jlaura

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes 126 and PVL grammar issue jlaura/plio
2 participants
@jlaura @ladoramkershner