make js calendar code easier to read #1058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this will cause any problems, but I'm not a js expert, so I'm not sure... This was made using https://beautifier.io
|
Or is this coming from https://www.addevent.com/add-to-calendar-button (or something similar), in which case this PR doesn't really matter as we're not going to fix it but might just see if there's a new version there that fixes this problem |
|
@vsoch - Do you know where this code came from? Did you write it, or get it from somewhere else? And if there's a problem with the events it is generating (they are off by an hour when the event is created in the other toggle of DST from when the event will occur), do you have any thoughts on how to fix it? |
|
closing as not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this will cause any problems, but I'm not a js expert, so I'm not sure...
This was made using https://beautifier.io
Description
Motivation and Context
Checklist:
cc @usrse-maintainers