trivial fix to make the tributors badge go to the correct section #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chad Dougherty <crd@acm.org>
kescobo
approved these changes
Jun 21, 2023
|
Here is the issue you want: all-contributors/all-contributors#615. For context, having (or not having) an emoji dictates that dash being correct or not. At one point (in the issue) it was a bug. A quick fix would be to add an emoji. |
|
Try adding the badge template explicitly, e.g., an example https://github.com/ruby-gh-actions/sandbox/blob/main/.all-contributorsrc |
|
Thanks. The badge template is probably the best solution. |
crd477
added a commit
to crd477/usrse.github.io
that referenced
this pull request
Jun 21, 2023
Contributors section This is the more complete fix for USRSE#1190 Signed-off-by: Chad Dougherty <crd@acm.org>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is just a trivial fix to make the link on the tributors badge go to the correct section.
Checklist:
When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.