Removing map endpoint in favor of usrse-map. #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cosden
requested changes
Apr 22, 2020
The data and page still exists, but the testing has been disabled to speed up the CI. This is being done in favor of completely deleting the includes and data files, in case we want to create another kind of map page. It does no damage to the site or performance cuts to keep the page present (but hidden). Signed-off-by: vsoch <vsochat@stanford.edu>
cosden
approved these changes
Apr 22, 2020
|
Looks good! It's a much nicer map and will grow with the community! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data and page still exists, but the testing has been disabled to speed up the CI. This is being done in favor of completely deleting the includes and data files, in case we want to create another kind of map page. It does no damage to the site or performance cuts to keep the page present (but hidden). The README has also been updated to mention these changes, and tell the reader how to add now to the map (just sign up for usrse!)
This will close #206
Signed-off-by: vsoch vsochat@stanford.edu
Description
Motivation and Context
Checklist:
cc @usrse-maintainers