Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating action set-env to write to GITHUB_ENV #326

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Nov 17, 2020

The set-env command is now deprecated, so the next time this action runs it will fail. This PR updates the action to more properly write to the GITHUB_ENV file, and the pull-request-action to the latest version that also has this update.

…precated

Signed-off-by: vsoch <vsochat@stanford.edu>
@vsoch vsoch changed the title updating action set-env to write to GITHUB_ENV now that command is de… updating action set-env to write to GITHUB_ENV Nov 17, 2020
Copy link
Member

@cosden cosden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me. And they are so minor, I don't see a problem merging, but is there a way to test it without triggering it with a new contributor PR?

@vsoch
Copy link
Member Author

vsoch commented Nov 18, 2020

I tested similar recipes with other actions and they worked A ok!

@cosden cosden merged commit b786d29 into master Nov 18, 2020
@cosden cosden deleted the update/set-env branch November 18, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants