removing the changelog #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since this is a website without proper releases, it does not server a purpose to have one This will close #412 Signed-off-by: vsoch <vsochat@stanford.edu>
|
LGTM 👍 |
cosden
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Looks good and makes sense.
I think there's a low likelihood of needing it. But the only reason I'd say not to do it, is if we come to the conclusion that we're going to keep what we have as a starting point and make a more formal release cycle moving forward. That is, there is a chance we might want this functionality later, but it's small and easily added back in.
|
If we aren't developing a template for others to use, we probably won't need it, but definitely could add again if we ever change our mind (it's actually also possible to generate from the commit history, and arguably we can look up a change there if needed). If it looks good to you @cosden please merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is a website without proper releases, having a CHANGELOG does not make sense. It does not server a purpose to have one This will close #412.
Signed-off-by: vsoch vsochat@stanford.edu
cc @usrse-maintainers