Adding support for youtube embed #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will update our first DEI speaker video to be embedded in the page, and I have added a style that will support page full width and full screen, and to make it easy I am adding an include and instructions for how to use it. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
Looks good!! Should we change the language in the first line, since the video is now embedded?
seems a little awkward. Maybe
|
|
@danielskatz I was actually just thinking of removing that line, because if the user just clicks "View on Youtube" they are taken to that page. Less is better, cleaner! |
sounds good |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
I think we can merge this at this point |
|
Sounds good! Would you like to do the honors @danielskatz ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update our first DEI speaker video to be embedded in the page, and I have added an include to make it easy to embed future videos that has style that will support page full width and full screen. I'm also adding instructions to the README for how to use it.
Signed-off-by: vsoch vsoch@users.noreply.github.com
Description
Motivation and Context
Checklist:
cc @usrse-maintainers