Added December DEI speaker series event page #569
Conversation
|
I'm confused by why there is just the URL check here, but not the action to build the site and create a preview. Did something change in our CI config? |
|
It also looks like the MBARI job (https://www.mbari.org/software_engineer/ "Software Engineer: Monterey Bay Aquarium Research Institute Posted: Sep 20, 2021") is not longer posted, so we probably need to remove that posting as part of this PR too |
|
No I just added a file in _event/ and added a line to .gitignore. I'm also confused by the message. It's not a url relating to my post. |
|
the way our CI works is that every change does a check of all URLs to see if anything has broken, and if so, then the PR needs to be changed to also fix the broken URL. |
|
Yes, I'll delete it |
|
I think you should remove lines 37-41 of _data/jobs.yml to fix this |
|
It's not your fault, you just happened to make the first PR after the URL broke and get stuck fixing it |
|
Alternatively, perhaps you could change the expiration date for the job to yesterday |
|
Right, I see. Thanks 😊 |
|
@danielskatz the urlchecker is agnostic to the expires date - it will still trigger that the URL is 404. |
|
so what's the right fix? remove the job? |
|
Your first suggestion was correct - yes - the job should be removed! Normally these get detected on a nightly run and I take care of it, but @nicole-brewer you are unlucky that the job 404'd between last night's run and now. |
|
Also, @vsoch - do you know why there was no site build/preview generated? |
|
@danielskatz I'm not 100% but I would suspect it's just a bloop in the checks API sending back the check from Circle. It actually did run (this says 22/23 minutes ago https://app.circleci.com/pipelines/github/nicole-brewer/usrse.github.io/7/workflows/cc0378f3-ff12-4733-9d3b-5413313d6d2b) but didn't show up here. |
|
To me, the two "Tech"s in the abstract should be "tech", but if this is the abstract the speaker provided, that's ok I guess |
|
I prefer the "Dr"s to be "Dr."s but again, not a big deal |
|
I wonder if we should change the data/time info to link to "find this in your own time zone" as well? |
|
How do I do that? |
|
@danielskatz the page should already render the event in the viewer's browser's time zone. Let me double check this one. |
|
yeah see I'm in Mountain and I see Mountain! ⭐
|
|
ok, I was thinking something like https://www.timeanddate.com/worldclock/fixedtime.html?msg=US-RSE+December+DEI+speaker&iso=20211210T00&p1=179&ah=1 could be used |
|
Add to calendar is also correct zone
|
|
since I do see the right time on the top, but I also see this |
|
yeah that's hard coded text in the Markdown: https://github.com/USRSE/usrse.github.io/pull/569/files#diff-3a753bbb9576a9bd8401a6c332cc987b127b0e5657773e183226a39e51fb0979R21. I guess I think it's okay generally because it gets the span of the US? Our other events surely vary in how they designate this part - some just have Eastern time. I think probably if there is to be a standard it should be discussed in the chat and then implemented across events. |
|
that's reasonable - just pointing out that we could make this friendlier to other time zones too, but not a big deal either way |
This follows the suggestions here: https://github.com/USRSE/usrse.github.io#3-how-do-i-add-an-event
|
|
Oh okay. I'll update one more time. |
There was a problem hiding this comment.
LGTM, a few minor suggestions I leave to your discretion:
- Period after
Dr - References to DEI-WG link to https://us-rse.org/about/working-groups/#diversity-equity-and-inclusion-dei
|
lol I totally wrote something similar in the README
Must have been 3am Vanessa because 3pm Vanessa doesn't remember that 😆 |
|
I think this is ready to go |
Checklist:
cc @usrse-maintainers