Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple taglines, select according to current day. #607

Closed
wants to merge 4 commits into from

Conversation

mtbc
Copy link
Contributor

@mtbc mtbc commented Nov 23, 2021

Description

Rather than having a fixed tagline, select one according to the current day from those in the configured hero_line_two list.

Occurs in building the site so doesn't rely on any JavaScript but should still change fairly frequently when we add jobs or events or whatever.

Motivation and Context

Assists #522.

Checklist:

  • I have posted the link for the PR in the usrse slack (#website) to ask for reviewers
  • I have previewed changes locally
  • I have updated the README.md if necessary

cc @usrse-maintainers

@vsoch
Copy link
Member

vsoch commented Nov 23, 2021

Oh this is so neat! Could you add some documentation to the README and alongside the code for the logic of how it works? And did you try the sample filter to randomly select so it doesn't depend on the date? And also, did you try adding more taglines to the list to see if it works pretty reliably?

@mtbc
Copy link
Contributor Author

mtbc commented Nov 23, 2021

Sure, happy to do those things, good idea.

I figured that depending on the day was nice because it does vary but isn't distractingly changing every time you do something, I tried to keep the site a bit deterministic and stable for rapid-cycle testing. Happy to switch to the random filter instead though if you prefer, it would simplify the code.

@vsoch
Copy link
Member

vsoch commented Nov 23, 2021

Let’s see what others think too!

@mtbc
Copy link
Contributor Author

mtbc commented Nov 23, 2021

I did try adding more taglines. 😄

@cosden
Copy link
Member

cosden commented Nov 29, 2021

@mtbc - this is so cool! I love it. How did I miss this last week?

We'll need to come up with some new taglines!

Without having given this tons of thought, I would think the ability to hit refresh and see the taglines change would be desirable. Someone who stumbles on it might want to see all them all at once without waiting for the next day. Same with someone like me who might want to take a screenshot with a very specific tagline chosen.

@mtbc
Copy link
Contributor Author

mtbc commented Nov 30, 2021

I would think the ability to hit refresh and see the taglines change

That's probably best via JavaScript thus rather different. Certainly something we can do but I am unlikely to soon get time to figure that one out so maybe we should keep the issue open then and add it as a requirement and just figure if this PR is a useful stepping stone toward that?

might want to take a screenshot with a very specific tagline chosen

It could be nice if the implementation cycled to the next, with an unobtrusive tweak of the DOM, each time the tagline is clicked.

@mtbc
Copy link
Contributor Author

mtbc commented Feb 10, 2022

Happy to switch to random filter for @vsoch or just close for now if this just distracts from @cosden's change-on-refresh goal (can update issue accordingly).

@vsoch
Copy link
Member

vsoch commented Feb 10, 2022

@mtbc I love the idea but I think we probably want this done from a list in a data file into javascript so refreshing the page changes the line.

@mtbc
Copy link
Contributor Author

mtbc commented Feb 10, 2022

Will update the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants