Fill space with navbar items for wide mobile view. #696
Conversation
|
Preview: https://1942-120906408-gh.circle-artifacts.com/0/usrse.github.io/index.html huh I'm not sure I like this better? It looks a little messy / weird. What do others think?
vs.
The latter is much more natural for a mobile layout. |
|
I agree about mobile, but since this is what I get on my desktop, I like the new version there. |
|
It may work for @danielskatz to have that odd mode only on the intermediate widths, I'll push that as an alternative then. |
|
See attached screenshots of how this looks to me in various widths - the 4th one is very odd, since it is missing the headers |
|
@danielskatz: Looks as if you don't have the latest commit? Yeah, I found it odd too that the headers are visible only on mouseover. That preexists my PR so I assume somebody liked it like that, I've no strong opinion either way. |
|
The headers was not related to mouse position, but just to window width. But I'll check the newest preview and see if this is still the case. |
|
Ok, the new part is consistent, though I do think not having the header show in the multi-column view is odd. I would much rather see them than not see them, particularly when the info is somewhat complex. Three screen shots follow, which seems reasonably otherwise. |
|
Ohh, interesting, yes - there is probably still a bit of CSS that needs tweaking to make them appear. I'll try to figure which is the culprit. |
|
... I've found it but will add a bit of extra styling too to help make it clear which down-arrow symbol matches which heading. |
mtbc
force-pushed
the
spread-navbar-dropdowns-across
branch
2 times, most recently
from
e2b6fbd
to
db77fb5
Compare
mtbc
force-pushed
the
spread-navbar-dropdowns-across
branch
from
db77fb5
to
42cced0
Compare
|
@danielskatz: I hope that this is nicer for you. |
|
This still feels/looks a little wonky to me. It looks fine as a single listing and then I get to a width and there are dropdown headers that probably shouldn't be dropdown because the links are expanded below them. |
|
Ah, I was just mirroring what the current site does, I can get rid of those down arrows in both of the narrow cases though - sounds like a good suggestion, @vsoch. |
|
Maybe this one's good. 🤞 |
|
That's definitely better! 👍 |
Description
Mobile view of popup navigation items from hamburger now spreads out horizontally across the screen if it is still quite wide.
Motivation and Context
Previously it looked rather a waste of screen for @danielskatz's view.
Checklist:
cc @usrse-maintainers