Added video recording to DEI Speaker Series event page #784
Conversation
|
Taking a look! Sorry for delay was giving a talk! |
|
That's weird no CircleCI preview - @nicole-brewer do you have Circle running on your account? I'll need to pull to preview. |
|
Did you preview this and it worked? I think we need a different strategy for youtube embeds - this looks like it won't work.
What about just copying the share link from the video? If the include is broken (deemed malicious now) we should replace wherever it's used with the actual embed. |
|
Also since you are PR-ing from main and this is going to be more than one commit, your main branch won't be synced with the main here (since we will squash and merge) and you are going to get a bunch of weird empty commits for future PRs. You might want to re-create your fork, pull, and then always check out a new branch when you PR. |
|
Actually I take it back - it's the link! The previous one works still: |
| @@ -12,6 +12,7 @@ time: | |||
| end: 2022-03-11T20:00:00Z | |||
| --- | |||
|
|
|||
| {% include youtube-embed.html url="https://youtu.be/BdDTC4JsPvw" title="DEI Webinar - Allies, Collaboration, & Communication" %} | |||
There was a problem hiding this comment.
Try this one!
| {% include youtube-embed.html url="https://youtu.be/BdDTC4JsPvw" title="DEI Webinar - Allies, Collaboration, & Communication" %} | |
| {% include youtube-embed.html url="https://www.youtube.com/embed/BdDTC4JsPvw" title="DEI Webinar - Allies, Collaboration, & Communication" %} |
|
Merged in #786 - @nicole-brewer I didn't squash so since it's just one commit here your main branch should be okay :) Remember to check out a new branch next time! Thanks for adding the video! |
cc @usrse-maintainers