-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(vitineth/feature/efficiency): increasing efficiency via multi-id queries #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arrays These are just quick shorthands that I have to write a lot so may be handy to have them here
Using this new ID system, I'm adding a system to look up values. This is basically the resolver system but I'm looking to migrate away from that so this will be the new system. Described more in flows of lookups rather than looking up every value required as they come in.
These are replacements for the entity resolver system when using multiples. Instead of resolving one event at a time it does them all at once.
Its a bad thing, never to be touched again
This was referenced May 22, 2022
This was referenced May 22, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases efficiency of fetching events and other composite assets across the system by adding support for multi-ID queries. Instead of resolving each entry individually, you can now send a batch of IDs to be resolved into requests. Restructuring requests in
gateway
using these new multi-id queries has improved efficiency 54x approximately.